[PATCH 17/20] nvme: query namespae identifiers before adding the namespace

Niklas Cassel Niklas.Cassel at wdc.com
Wed Sep 30 05:44:12 EDT 2020


On Mon, Sep 28, 2020 at 02:34:59PM +0200, Christoph Hellwig wrote:
> Check the namespace identifier list first thing when scanning namespaces.
> This keeps the code to query the CSI common between the alloc and validate
> path, and helps to structure the code better for multiple command set
> support.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> ---
>  drivers/nvme/host/core.c | 116 ++++++++++++++++++---------------------
>  1 file changed, 53 insertions(+), 63 deletions(-)

For the subject of this patch:
s/namespae/namespace



In your v1 series, you had a separate patch for:

"
nvme: remove the namespace identifier verification in __nvme_validate_ns

None of the identifiers (including the new CSI) can cange over the life
time of a namespace, so don't bother with the extra query here.
"

which now seems to have been squashed with this patch.

Squashing it is fine, but perhaps you could add that information in this
commit message?


Kind regards,
Niklas


More information about the Linux-nvme mailing list