[PATCH] nvme-core: don't use NVME_NSID_ALL for cmd-effect
hch at lst.de
hch at lst.de
Wed Sep 23 14:02:29 EDT 2020
On Wed, Sep 23, 2020 at 10:35:44AM -0700, Keith Busch wrote:
> On Tue, Sep 22, 2020 at 09:04:36PM +0000, Chaitanya Kulkarni wrote:
> > In the function nvme_get_effects_log() it uses NVME_NSID_ALL which has
> > namespace scope. The command effect log page is controller specific.
> >
> > Replace NVME_NSID_ALL with 0x00 which specifies the controller scope
> > instead of namespace scope.
> >
> > Reported-by: Huai-Cheng Kuo <hh81478072 at gmail.com>
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=209287
> > Fixes: be93e87e7802 ("nvme: support for multiple Command Sets Supported and Effects log pages")
>
> This is actually the wrong fixes tag. The code was simply carried
> forward from 84fef62d135b6.
>
> But otherwise, yes, this looks correct.
I've fixed up the fixes tag in the nvme-5.9 branch.
More information about the Linux-nvme
mailing list