[PATCH V3 1/7] nvme-core: use I/O timeout in submit sync cmd

[Chaitanya Kulkarni]

On 9/16/20 00:09, Christoph Hellwig wrote:
>> +	req->timeout = timeout;
> The void *queuedata thing is really weird.
> 
> I'd keep the check for an existing timeout in the callers and just
> write this as:
> 
> static inline void nvme_req_set_default_timeout(struct request *req)
> {
> 	if (req->queuedata)
> 		req->timeout = NVME_IO_TIMEOUT
> 	else /* no queuedata implies admin queue */
> 		req->timeout = ADMIN_TIMEOUT;
> }
> 

Okay I'll add in V4.